[L-01] VestingWallet audit - 417#463
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates operational documentation around VestingWallet teardown to clarify retryability and stranded-funds risk in the presence of newly settled or in-flight funds.
Changes:
- Clarifies that
destroy_emptycan abort withEUnsweptFundswhen third-party funds settle before teardown, so teardown should be treated as retryable (sweep then retry). - Expands the warning that funds sent in the same checkpoint as teardown (or after UID deletion) may become permanently unrecoverable, recommending waiting at least one full checkpoint before teardown.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contracts/finance/sources/vesting_wallet.move | Refines destroy_empty documentation to emphasize retryability on EUnsweptFunds and checkpoint-related stranded-funds risk. |
| contracts/finance/sources/vesting_wallet_linear.move | Updates linear wallet teardown docs to match core wallet guidance on retryability and checkpoint timing risks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-v1.4 #463 +/- ##
=============================================
Coverage 80.36% 80.36%
=============================================
Files 25 25
Lines 1971 1971
Branches 679 678 -1
=============================================
Hits 1584 1584
Misses 350 350
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0xNeshi
approved these changes
Jul 8, 2026
ericnordelo
added a commit
that referenced
this pull request
Jul 9, 2026
* fix: N-02 (#447) * fix: N-03 (#448) * fix: N-04 (#449) * fix: N-01 (#446) * fix: N-06 (#451) * fix: N-07 (#452) * [N-08] VestingWallet audit (#453) * fix: N-08 * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * fix: N-05 (#450) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Add PR417 changes to release v1.4 (#456) * feat: update comment * feat: Make VestingWallet work with address balances (#417) * feat: use balance instead of coin * test: fix tests * test: fix * ref: use releasable inside release * feat: update destroy_empty to check address balance too * docs: add missing sections and field docs * docs: fix minor leftovers * docs: sync pausable_grant header with current API * docs: add missing doc sections to splitter * docs: update stale docs that refd Coin as focus on VW * docs: update splitter docs * docs: add TODO for splitter::disperse * feat: merge + add Swept event * test: add test stubs for sweep * docs: Extended the destroy_empty caveat to cover both stranding paths * ref: apply code-quality to vesting_wallet.move * ref: apply code-quality to vesting_wallet_linear.move * ref: apply code-quality to tests * ref: apply code-quality to examples --------- Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com> (cherry picked from commit 85448ce) * feat: apply review updates * Update contracts/finance/sources/vesting_wallet.move Co-authored-by: Nenad <nenad.misic@openzeppelin.com> --------- Co-authored-by: Nenad <nenad.misic@openzeppelin.com> Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com> * feat: re-apply fix (#466) * fix: L-01 (#463) * [N-01] VestingWallet audit - 417 (#464) * fix: N-01 * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: N-02 (#465) * feat: bring allowance (#467) * Prepare release 1.4 (#468) * feat: bring allowance * feat: prepare release * feat: update READMEs * fix: workflow --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Nenad <nenad.misic@openzeppelin.com> Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.